From 2b707343577193fc9904517e6078149653e95698 Mon Sep 17 00:00:00 2001 From: gewuyou <95328647+GeWuYou@users.noreply.github.com> Date: Fri, 24 Apr 2026 20:05:14 +0800 Subject: [PATCH] =?UTF-8?q?fix(game-tests):=20=E6=B8=85=E7=90=86=E6=8C=81?= =?UTF-8?q?=E4=B9=85=E5=8C=96=E6=B5=8B=E8=AF=95=E6=AE=8B=E4=BD=99=E5=91=8A?= =?UTF-8?q?=E8=AD=A6?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 修复 PersistenceTests 中统一设置仓库失败场景测试的剩余 ConfigureAwait 告警\n- 验证 PersistenceTests 不再出现在非增量 GFramework.Game.Tests 构建告警输出中\n- 更新 analyzer warning reduction 的 tracking 与 trace，记录 RP-057 验证结果和当前分支体积 --- .../Data/PersistenceTests.cs | 19 +++++++------ .../analyzer-warning-reduction-tracking.md | 28 +++++++++++-------- .../analyzer-warning-reduction-trace.md | 23 +++++++++++++++ 3 files changed, 50 insertions(+), 20 deletions(-) diff --git a/GFramework.Game.Tests/Data/PersistenceTests.cs b/GFramework.Game.Tests/Data/PersistenceTests.cs index 4cbcc5e0..4daefddc 100644 --- a/GFramework.Game.Tests/Data/PersistenceTests.cs +++ b/GFramework.Game.Tests/Data/PersistenceTests.cs @@ -595,11 +595,11 @@ public class PersistenceTests Assert.ThrowsAsync( async () => await repository.SaveAsync(primaryLocation, new TestSimpleData { Value = 99 }).ConfigureAwait(false)); - var cachedAfterFailure = await repository.LoadAsync(primaryLocation); + var cachedAfterFailure = await repository.LoadAsync(primaryLocation).ConfigureAwait(false); Assert.That(cachedAfterFailure.Value, Is.EqualTo(1)); throwingStorage.ThrowOnWrite = false; - await repository.SaveAsync(secondaryLocation, new TestSimpleData { Value = 7 }); + await repository.SaveAsync(secondaryLocation, new TestSimpleData { Value = 7 }).ConfigureAwait(false); using var verifyStorage = new FileStorage(root, new JsonSerializer(), ".json"); var verifyRepository = new UnifiedSettingsDataRepository( @@ -609,8 +609,8 @@ public class PersistenceTests verifyRepository.RegisterDataType(primaryLocation, typeof(TestSimpleData)); verifyRepository.RegisterDataType(secondaryLocation, typeof(TestSimpleData)); - var persistedPrimary = await verifyRepository.LoadAsync(primaryLocation); - var persistedSecondary = await verifyRepository.LoadAsync(secondaryLocation); + var persistedPrimary = await verifyRepository.LoadAsync(primaryLocation).ConfigureAwait(false); + var persistedSecondary = await verifyRepository.LoadAsync(secondaryLocation).ConfigureAwait(false); Assert.Multiple(() => { @@ -655,12 +655,13 @@ public class PersistenceTests repository.RegisterDataType(secondaryLocation, typeof(TestSimpleData)); throwingStorage.ThrowOnWrite = true; - Assert.ThrowsAsync(async () => await repository.DeleteAsync(secondaryLocation)); + Assert.ThrowsAsync( + async () => await repository.DeleteAsync(secondaryLocation).ConfigureAwait(false)); - Assert.That(await repository.ExistsAsync(secondaryLocation), Is.True); + Assert.That(await repository.ExistsAsync(secondaryLocation).ConfigureAwait(false), Is.True); throwingStorage.ThrowOnWrite = false; - await repository.SaveAsync(primaryLocation, new TestSimpleData { Value = 9 }); + await repository.SaveAsync(primaryLocation, new TestSimpleData { Value = 9 }).ConfigureAwait(false); using var verifyStorage = new FileStorage(root, new JsonSerializer(), ".json"); var verifyRepository = new UnifiedSettingsDataRepository( @@ -670,8 +671,8 @@ public class PersistenceTests verifyRepository.RegisterDataType(primaryLocation, typeof(TestSimpleData)); verifyRepository.RegisterDataType(secondaryLocation, typeof(TestSimpleData)); - var persistedPrimary = await verifyRepository.LoadAsync(primaryLocation); - var persistedSecondary = await verifyRepository.LoadAsync(secondaryLocation); + var persistedPrimary = await verifyRepository.LoadAsync(primaryLocation).ConfigureAwait(false); + var persistedSecondary = await verifyRepository.LoadAsync(secondaryLocation).ConfigureAwait(false); Assert.Multiple(() => { diff --git a/ai-plan/public/analyzer-warning-reduction/todos/analyzer-warning-reduction-tracking.md b/ai-plan/public/analyzer-warning-reduction/todos/analyzer-warning-reduction-tracking.md index 00b10d77..41fe7647 100644 --- a/ai-plan/public/analyzer-warning-reduction/todos/analyzer-warning-reduction-tracking.md +++ b/ai-plan/public/analyzer-warning-reduction/todos/analyzer-warning-reduction-tracking.md @@ -6,22 +6,23 @@ ## 当前恢复点 -- 恢复点编号：`ANALYZER-WARNING-REDUCTION-RP-056` -- 当前阶段：`Phase 56` +- 恢复点编号：`ANALYZER-WARNING-REDUCTION-RP-057` +- 当前阶段：`Phase 57` - 当前焦点： - - `2026-04-24` 本轮延续 `RP-055` 的 `GFramework.Game.Tests` 小热点批次，修复了 `GeneratedConfigConsumerIntegrationTests.cs` 中 raw string 缩进导致的编译错误 - - 进一步将 `GeneratedConfigConsumerIntegrationTests.cs` 的长断言逻辑拆分为多个辅助方法，并补齐异步等待的 `.ConfigureAwait(false)`，使该文件不再出现在项目构建 warning 输出中 - - `dotnet build GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release` 已从上一轮收尾的 `63 Warning(s)` 进一步收敛到 `59 Warning(s)` - - 按当前工作树投影重新计算后，分支体积为 `27` 个文件、`943` 行，仍低于 `$gframework-batch-boot 75` + - `2026-04-24` 本轮继续吃掉 `GFramework.Game.Tests` 中仍然独立且低风险的 `PersistenceTests.cs` 残余 `MA0004` + - 已补齐两个失败缓存一致性测试中的剩余 `.ConfigureAwait(false)`，使 `PersistenceTests.cs` 不再出现在非增量构建 warning 输出中 + - 非增量 `dotnet build GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --no-incremental` 从 `253 Warning(s)` 进一步收敛到 `249 Warning(s)`，剩余热点几乎全部集中在 `YamlConfigLoaderTests.cs` + - 按当前工作树投影重新计算后，分支体积为 `27` 个文件、`991` 行，仍低于 `$gframework-batch-boot 75` ## 当前活跃事实 - 之前记录的 plain `dotnet build` `0 Warning(s)` 属于增量构建假阴性，不能再作为 warning 检查真值 - 仓库根目录 `dotnet clean GFramework.sln -c Release` 仍在 `ValidateSolutionConfiguration` 阶段失败，项目级 `dotnet clean GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release` 也未能稳定提供 clean 基线 - 当前整仓最近一次直接观测值仍是 `dotnet build GFramework.sln -c Release` 的 `116 warning(s)` -- `RP-055` 后续补批已验证 `dotnet build GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release`，结果为 `59 Warning(s)`、`0 Error(s)` -- 本轮已验证 `dotnet test GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --filter "FullyQualifiedName~GeneratedConfigConsumerIntegrationTests"`，结果为 `Passed: 4` -- `GeneratedConfigConsumerIntegrationTests.cs` 当前已不再出现在项目 build warning 输出中；`GFramework.Game.Tests` 剩余热点进一步集中到未触碰的 `YamlConfigLoaderTests.cs` 等高上下文文件 +- `RP-056` 已验证 `GeneratedConfigConsumerIntegrationTests.cs` 不再出现在项目 build warning 输出中 +- `RP-057` 已验证 `PersistenceTests.cs` 不再出现在 `dotnet build GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --no-incremental` 的 warning 输出中 +- 本轮已验证 `dotnet test GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --filter "FullyQualifiedName~UnifiedSettingsDataRepository_SaveAsync_When_Persist_Fails_Should_Keep_Cache_Consistent|FullyQualifiedName~UnifiedSettingsDataRepository_DeleteAsync_When_Persist_Fails_Should_Keep_Cache_Consistent"`，结果为 `Passed: 2` +- `GFramework.Game.Tests` 当前剩余热点已经几乎完全集中到 `YamlConfigLoaderTests.cs` 这一高上下文文件 ## 当前风险 @@ -57,12 +58,17 @@ - `dotnet build GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release` - `RP-055` 收尾结果：成功；`63 Warning(s)`、`0 Error(s)` - `RP-056` 当前结果：成功；`59 Warning(s)`、`0 Error(s)` +- `dotnet build GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --no-incremental` + - `RP-057` 热点重排前：成功；`253 Warning(s)`、`0 Error(s)` + - `RP-057` 当前结果：成功；`249 Warning(s)`、`0 Error(s)` - `dotnet test GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --filter "FullyQualifiedName~ArchitectureConfigIntegrationTests|FullyQualifiedName~GameConfigBootstrapTests|FullyQualifiedName~JsonSerializerTests"` - 结果：成功；`Passed: 19`、`Failed: 0` - `dotnet test GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --filter "FullyQualifiedName~GeneratedConfigConsumerIntegrationTests"` - 结果：成功；`Passed: 4`、`Failed: 0` +- `dotnet test GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --filter "FullyQualifiedName~UnifiedSettingsDataRepository_SaveAsync_When_Persist_Fails_Should_Keep_Cache_Consistent|FullyQualifiedName~UnifiedSettingsDataRepository_DeleteAsync_When_Persist_Fails_Should_Keep_Cache_Consistent"` + - 结果：成功；`Passed: 2`、`Failed: 0` ## 下一步建议 -1. 提交 `GeneratedConfigConsumerIntegrationTests.cs` 与 `RP-056` tracking/trace 更新，继续保持只纳入本 topic 相关文件 -2. 下一轮若继续 warning reduction，应优先决定是否接受进入 `YamlConfigLoaderTests.cs` 的高上下文批次 +1. 提交 `PersistenceTests.cs` 与 `RP-057` tracking/trace 更新，继续保持只纳入本 topic 相关文件 +2. 若继续 warning reduction，应把 `YamlConfigLoaderTests.cs` 视为独立的高上下文批次，不再与其它文件混批 diff --git a/ai-plan/public/analyzer-warning-reduction/traces/analyzer-warning-reduction-trace.md b/ai-plan/public/analyzer-warning-reduction/traces/analyzer-warning-reduction-trace.md index 164df0dc..5363a4d3 100644 --- a/ai-plan/public/analyzer-warning-reduction/traces/analyzer-warning-reduction-trace.md +++ b/ai-plan/public/analyzer-warning-reduction/traces/analyzer-warning-reduction-trace.md @@ -2,6 +2,29 @@ # Analyzer Warning Reduction 追踪 +## 2026-04-24 — RP-057 + +### 阶段：清理 `PersistenceTests.cs` 残余 `MA0004` + +- 触发背景： + - `RP-056` 提交后重新做非增量热点排序时，`GFramework.Game.Tests` 的剩余测试项目 warning 已明显收敛，只剩 `PersistenceTests.cs` 少量 `MA0004` 与 `YamlConfigLoaderTests.cs` 大量 warning + - 为避免在同一轮直接进入 `YamlConfigLoaderTests.cs` 的大文件高上下文批次，先吃掉 `PersistenceTests.cs` 这个独立小切片 +- 主线程实施： + - 在 `PersistenceTests.cs` 中为统一设置仓库失败缓存一致性相关测试补齐剩余 `.ConfigureAwait(false)` + - 覆盖保存失败与删除失败两个测试场景中的缓存读取、存在性检查、后续保存和最终验证读取 + - 更新 active tracking / trace，明确下一批若继续推进应单独进入 `YamlConfigLoaderTests.cs` +- 验证里程碑： + - `dotnet build GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --no-incremental` + - 热点重排前：成功；`253 Warning(s)`、`0 Error(s)` + - 修复后：成功；`249 Warning(s)`、`0 Error(s)` + - 结论：`PersistenceTests.cs` 不再出现在 warning 输出中 + - `dotnet test GFramework.Game.Tests/GFramework.Game.Tests.csproj -c Release --filter "FullyQualifiedName~UnifiedSettingsDataRepository_SaveAsync_When_Persist_Fails_Should_Keep_Cache_Consistent|FullyQualifiedName~UnifiedSettingsDataRepository_DeleteAsync_When_Persist_Fails_Should_Keep_Cache_Consistent"` + - 结果：成功；`Passed: 2`、`Failed: 0` +- 当前结论： + - `PersistenceTests.cs` 的残余 warning 已清零，`GFramework.Game.Tests` 剩余热点几乎全部压缩到了 `YamlConfigLoaderTests.cs` + - 当前工作树投影下，分支体积为 `27` 个文件、`991` 行，仍低于 `$gframework-batch-boot 75` + - 按 batch skill 的低风险边界，这一轮应在提交后收口；下一轮再把 `YamlConfigLoaderTests.cs` 作为单独批次处理 + ## 2026-04-24 — RP-056 ### 阶段：修复 `GeneratedConfigConsumerIntegrationTests` 编译错误并清零该文件 warning