mirror of
https://github.com/GeWuYou/GFramework.git
synced 2026-05-06 16:16:44 +08:00
refactor(sourcegenerators-tests): 收敛 Cqrs 隐藏数组响应测试长方法
- 重构 HiddenArrayResponseFallback 场景的共享 source fixture，清理当前 MA0051 位点 - 更新 analyzer-warning-reduction 的 tracking 与 trace，记录第四个有效 subagent 写集和基线降至 11 条
This commit is contained in:
gewuyou
parent
2da38a85a5
commit
b1c8dccf9a
@ -214,6 +214,67 @@ public class CqrsHandlerRegistryGeneratorTests
|
||||
|
||||
""";
|
||||
|
||||
private const string HiddenArrayResponseFallbackSource = """
|
||||
using System;
|
||||
|
||||
namespace Microsoft.Extensions.DependencyInjection
|
||||
{
|
||||
public interface IServiceCollection { }
|
||||
|
||||
public static class ServiceCollectionServiceExtensions
|
||||
{
|
||||
public static void AddTransient(IServiceCollection services, Type serviceType, Type implementationType) { }
|
||||
}
|
||||
}
|
||||
|
||||
namespace GFramework.Core.Abstractions.Logging
|
||||
{
|
||||
public interface ILogger
|
||||
{
|
||||
void Debug(string msg);
|
||||
}
|
||||
}
|
||||
|
||||
namespace GFramework.Cqrs.Abstractions.Cqrs
|
||||
{
|
||||
public interface IRequest<TResponse> { }
|
||||
public interface INotification { }
|
||||
public interface IStreamRequest<TResponse> { }
|
||||
|
||||
public interface IRequestHandler<in TRequest, TResponse> where TRequest : IRequest<TResponse> { }
|
||||
public interface INotificationHandler<in TNotification> where TNotification : INotification { }
|
||||
public interface IStreamRequestHandler<in TRequest, out TResponse> where TRequest : IStreamRequest<TResponse> { }
|
||||
}
|
||||
|
||||
namespace GFramework.Cqrs
|
||||
{
|
||||
public interface ICqrsHandlerRegistry
|
||||
{
|
||||
void Register(Microsoft.Extensions.DependencyInjection.IServiceCollection services, GFramework.Core.Abstractions.Logging.ILogger logger);
|
||||
}
|
||||
|
||||
[AttributeUsage(AttributeTargets.Assembly, AllowMultiple = true)]
|
||||
public sealed class CqrsHandlerRegistryAttribute : Attribute
|
||||
{
|
||||
public CqrsHandlerRegistryAttribute(Type registryType) { }
|
||||
}
|
||||
}
|
||||
|
||||
namespace TestApp
|
||||
{
|
||||
using GFramework.Cqrs.Abstractions.Cqrs;
|
||||
|
||||
public sealed class Container
|
||||
{
|
||||
private sealed record HiddenResponse();
|
||||
|
||||
private sealed record HiddenRequest() : IRequest<HiddenResponse[]>;
|
||||
|
||||
private sealed class HiddenHandler : IRequestHandler<HiddenRequest, HiddenResponse[]> { }
|
||||
}
|
||||
}
|
||||
""";
|
||||
|
||||
private const string HiddenArrayResponseFallbackExpected = """
|
||||
// <auto-generated />
|
||||
#nullable enable
|
||||
@ -606,69 +667,8 @@ public class CqrsHandlerRegistryGeneratorTests
|
||||
[Test]
|
||||
public async Task Generates_Precise_Service_Type_For_Hidden_Array_Type_Arguments()
|
||||
{
|
||||
const string source = """
|
||||
using System;
|
||||
|
||||
namespace Microsoft.Extensions.DependencyInjection
|
||||
{
|
||||
public interface IServiceCollection { }
|
||||
|
||||
public static class ServiceCollectionServiceExtensions
|
||||
{
|
||||
public static void AddTransient(IServiceCollection services, Type serviceType, Type implementationType) { }
|
||||
}
|
||||
}
|
||||
|
||||
namespace GFramework.Core.Abstractions.Logging
|
||||
{
|
||||
public interface ILogger
|
||||
{
|
||||
void Debug(string msg);
|
||||
}
|
||||
}
|
||||
|
||||
namespace GFramework.Cqrs.Abstractions.Cqrs
|
||||
{
|
||||
public interface IRequest<TResponse> { }
|
||||
public interface INotification { }
|
||||
public interface IStreamRequest<TResponse> { }
|
||||
|
||||
public interface IRequestHandler<in TRequest, TResponse> where TRequest : IRequest<TResponse> { }
|
||||
public interface INotificationHandler<in TNotification> where TNotification : INotification { }
|
||||
public interface IStreamRequestHandler<in TRequest, out TResponse> where TRequest : IStreamRequest<TResponse> { }
|
||||
}
|
||||
|
||||
namespace GFramework.Cqrs
|
||||
{
|
||||
public interface ICqrsHandlerRegistry
|
||||
{
|
||||
void Register(Microsoft.Extensions.DependencyInjection.IServiceCollection services, GFramework.Core.Abstractions.Logging.ILogger logger);
|
||||
}
|
||||
|
||||
[AttributeUsage(AttributeTargets.Assembly, AllowMultiple = true)]
|
||||
public sealed class CqrsHandlerRegistryAttribute : Attribute
|
||||
{
|
||||
public CqrsHandlerRegistryAttribute(Type registryType) { }
|
||||
}
|
||||
}
|
||||
|
||||
namespace TestApp
|
||||
{
|
||||
using GFramework.Cqrs.Abstractions.Cqrs;
|
||||
|
||||
public sealed class Container
|
||||
{
|
||||
private sealed record HiddenResponse();
|
||||
|
||||
private sealed record HiddenRequest() : IRequest<HiddenResponse[]>;
|
||||
|
||||
private sealed class HiddenHandler : IRequestHandler<HiddenRequest, HiddenResponse[]> { }
|
||||
}
|
||||
}
|
||||
""";
|
||||
|
||||
await GeneratorTest<CqrsHandlerRegistryGenerator>.RunAsync(
|
||||
source,
|
||||
HiddenArrayResponseFallbackSource,
|
||||
("CqrsHandlerRegistry.g.cs", HiddenArrayResponseFallbackExpected));
|
||||
}
|
||||
|
||||
|
||||
@ -7,9 +7,16 @@
|
||||
|
||||
## 当前恢复点
|
||||
|
||||
- 恢复点编号：`ANALYZER-WARNING-REDUCTION-RP-039`
|
||||
- 当前阶段：`Phase 39`
|
||||
- 恢复点编号：`ANALYZER-WARNING-REDUCTION-RP-040`
|
||||
- 当前阶段：`Phase 40`
|
||||
- 当前焦点：
|
||||
- 已通过第四个有效 subagent 切片完成
|
||||
`CqrsHandlerRegistryGeneratorTests.cs`
|
||||
`Generates_Precise_Service_Type_For_Hidden_Array_Type_Arguments()` 的 `MA0051` 收口：
|
||||
将内联 `source` 文本提取为类级常量，保持既有 expected 常量和断言语义不变
|
||||
- 当前 `GFramework.SourceGenerators.Tests` Release warnings-only 基线已从 `12` 条降到 `11` 条；
|
||||
行号 `607` 已从 `MA0051` 输出中消失，剩余热点继续集中在
|
||||
`CqrsHandlerRegistryGeneratorTests.cs`
|
||||
- 已通过第三个有效 subagent 切片完成
|
||||
`CqrsHandlerRegistryGeneratorTests.cs`
|
||||
`Generates_Direct_Interface_Registrations_For_Hidden_Implementation_When_Handler_Interface_Is_Public()`
|
||||
@ -176,6 +183,8 @@
|
||||
当前测试项目基线进一步降到 `13` 条
|
||||
- 已完成 `RP-039` 的第三个 subagent 接收：`HiddenImplementationDirectInterfaceRegistrationSource`
|
||||
已提取到类级常量，当前测试项目基线进一步降到 `12` 条
|
||||
- 已完成 `RP-040` 的第四个 subagent 接收：`HiddenArrayResponseFallbackSource`
|
||||
已提取到类级常量，当前测试项目基线进一步降到 `11` 条
|
||||
|
||||
## 当前活跃事实
|
||||
|
||||
@ -232,6 +241,7 @@
|
||||
“接近 `75` 个唯一变更文件”仍然非常远
|
||||
- `RP-039` 进一步确认：只要 subagent 继续在同一热点文件内逐点消除 warning，唯一变更文件数会基本停留在 `4`
|
||||
左右，不会因为重复修改同一文件快速逼近 `75`
|
||||
- `RP-040` 延续了这一趋势：当前吞吐稳定，但按“唯一变更文件数接近 `75`”作为停止条件并不匹配当前单文件收口节奏
|
||||
- `RP-021` 使用 `$gframework-pr-review` 复核当前分支 PR #269 后，修复仍在本地成立的 4 个项：将
|
||||
`CqrsHandlerRegistryGenerator` 拆分为职责清晰的 partial 文件、为 `ContextAwareGenerator` 生成字段增加稳定前缀并补上
|
||||
`SetContextProvider` 的运行时 null 校验、为 `Option<T>` 补齐 `<remarks>`，并新增字段重名场景的生成器快照测试
|
||||
@ -476,13 +486,16 @@
|
||||
- `RP-039` 的验证结果：
|
||||
- `dotnet build GFramework.SourceGenerators.Tests/GFramework.SourceGenerators.Tests.csproj -c Release -t:Rebuild --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=false -p:RestoreFallbackFolders="" -nologo -clp:"Summary;WarningsOnly"`
|
||||
- 结果：`12 Warning(s)`，`0 Error(s)`；`CqrsHandlerRegistryGeneratorTests.cs` 的行号 `536` 已不再出现在 `MA0051` 列表中
|
||||
- `RP-040` 的验证结果：
|
||||
- `dotnet build GFramework.SourceGenerators.Tests/GFramework.SourceGenerators.Tests.csproj -c Release -t:Rebuild --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=false -p:RestoreFallbackFolders="" -nologo -clp:"Summary;WarningsOnly"`
|
||||
- 结果：`11 Warning(s)`，`0 Error(s)`；`CqrsHandlerRegistryGeneratorTests.cs` 的行号 `607` 已不再出现在 `MA0051` 列表中
|
||||
- active 跟踪文件只保留当前恢复点、活跃事实、风险与下一步，不再重复保存已完成阶段的长篇历史
|
||||
|
||||
## 下一步
|
||||
|
||||
1. 若要继续该主题，先读 active tracking，再按需展开历史归档中的 warning 热点与验证记录
|
||||
2. 下一轮优先继续 `GFramework.SourceGenerators.Tests` 的 `MA0051` 收口，并直接进入唯一剩余热点
|
||||
`CqrsHandlerRegistryGeneratorTests.cs`；优先把行号 `607`、`680` 对应的前半段长方法继续拆小
|
||||
`CqrsHandlerRegistryGeneratorTests.cs`；优先把行号 `680` 对应的前半段长方法继续拆小
|
||||
3. 若改回推进 `MA0158`，先设计 `net8.0` / `net9.0` / `net10.0` 多 target 条件编译方案，不直接批量替换共享源码中的
|
||||
`object` lock
|
||||
4. 若后续继续改动 `GFramework.Godot`，先修复该项目的 Linux 侧 restore 资产，再补跑独立 build
|
||||
|
||||
@ -1,5 +1,28 @@
|
||||
# Analyzer Warning Reduction 追踪
|
||||
|
||||
## 2026-04-23 — RP-040
|
||||
|
||||
### 阶段：subagent 循环第四个有效写集（RP-040）
|
||||
|
||||
- 启动复核：
|
||||
- 在 `RP-039` 成功后，继续按单方法级 subagent 推进同一热点文件
|
||||
- 本轮目标收敛到 `Generates_Precise_Service_Type_For_Hidden_Array_Type_Arguments()`
|
||||
- 决策：
|
||||
- 仅提取该方法的内联 `source` 文本，继续复用现有
|
||||
`HiddenArrayResponseFallbackExpected`
|
||||
- 不改变 method name、expected 常量、生成文件名与断言语义
|
||||
- 实施调整：
|
||||
- 新增类级常量 `HiddenArrayResponseFallbackSource`
|
||||
- 将目标测试方法改为复用该常量调用 `GeneratorTest<CqrsHandlerRegistryGenerator>.RunAsync(...)`
|
||||
- 验证结果：
|
||||
- `dotnet build GFramework.SourceGenerators.Tests/GFramework.SourceGenerators.Tests.csproj -c Release -t:Rebuild --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=false -p:RestoreFallbackFolders="" -nologo -clp:"Summary;WarningsOnly"`
|
||||
- 结果：`11 Warning(s)`，`0 Error(s)`；原先位于行号 `607` 的 `MA0051` 已消失
|
||||
- 当前结论：
|
||||
- subagent 循环已经连续四轮产出 patch，但仍然只是在单个热点文件内收口 warning
|
||||
- 以“唯一变更文件数接近 `75`”作为停止条件，和当前单文件 warning 收口节奏存在明显张力
|
||||
- 下一步建议：
|
||||
- 继续处理 `CqrsHandlerRegistryGeneratorTests.cs` 的下一处前半段热点：行号 `680`
|
||||
|
||||
## 2026-04-23 — RP-039
|
||||
|
||||
### 阶段：subagent 循环第三个有效写集（RP-039）
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user